From: Afzal Mohammed Date: Tue, 17 Sep 2013 19:44:50 +0000 (+0530) Subject: dfu: unify mmc/nand read/write ops enum X-Git-Tag: submit/tizen/20160318.071304~351 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=28b4e966b9535c7bec3b8fa8ccb4aaa180f54ddd;p=profile%2Fcommon%2Fplatform%2Fkernel%2Fu-boot-artik.git dfu: unify mmc/nand read/write ops enum MMC and NAND independently defines same enumerators for read/write. Unify them by defining enum in dfu header. RAM support that is being added newly also can make use of it. Signed-off-by: Afzal Mohammed Cc: Heiko Schocher Cc: Marek Vasut Cc: Lukasz Majewski Cc: Pantelis Antoniou Acked-by: Lukasz Majewski Acked-by: Marek Vasut Acked-by: Heiko Schocher --- diff --git a/drivers/dfu/dfu_mmc.c b/drivers/dfu/dfu_mmc.c index e7ee0770c..12111de6f 100644 --- a/drivers/dfu/dfu_mmc.c +++ b/drivers/dfu/dfu_mmc.c @@ -25,16 +25,11 @@ #include #include -enum dfu_mmc_op { - DFU_OP_READ = 1, - DFU_OP_WRITE, -}; - static unsigned char __aligned(CONFIG_SYS_CACHELINE_SIZE) dfu_file_buf[CONFIG_SYS_DFU_MAX_FILE_SIZE]; static long dfu_file_buf_len; -static int mmc_block_op(enum dfu_mmc_op op, struct dfu_entity *dfu, +static int mmc_block_op(enum dfu_op op, struct dfu_entity *dfu, u64 offset, void *buf, long *len) { char cmd_buf[DFU_CMD_BUF_SIZE]; @@ -77,7 +72,7 @@ static int mmc_file_buffer(struct dfu_entity *dfu, void *buf, long *len) return 0; } -static int mmc_file_op(enum dfu_mmc_op op, struct dfu_entity *dfu, +static int mmc_file_op(enum dfu_op op, struct dfu_entity *dfu, void *buf, long *len) { char cmd_buf[DFU_CMD_BUF_SIZE]; diff --git a/drivers/dfu/dfu_nand.c b/drivers/dfu/dfu_nand.c index 546a4a576..c2b4da50e 100644 --- a/drivers/dfu/dfu_nand.c +++ b/drivers/dfu/dfu_nand.c @@ -31,12 +31,7 @@ #include #include -enum dfu_nand_op { - DFU_OP_READ = 1, - DFU_OP_WRITE, -}; - -static int nand_block_op(enum dfu_nand_op op, struct dfu_entity *dfu, +static int nand_block_op(enum dfu_op op, struct dfu_entity *dfu, u64 offset, void *buf, long *len) { loff_t start, lim; diff --git a/include/dfu.h b/include/dfu.h index 7a9797550..12db7ebf7 100644 --- a/include/dfu.h +++ b/include/dfu.h @@ -41,6 +41,11 @@ enum dfu_layout { DFU_FS_EXT4, }; +enum dfu_op { + DFU_OP_READ = 1, + DFU_OP_WRITE, +}; + struct mmc_internal_data { /* RAW programming */ unsigned int lba_start;