From: Max Gurtovoy <maxg@mellanox.com>
Date: Sun, 13 Oct 2019 16:57:38 +0000 (+0300)
Subject: nvme-tcp: fix possible leakage during error flow
X-Git-Tag: v5.15~5280^2^2~1
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=28a4cac48c7e897a0b4e7d79a53a8e4fe40337ae;p=platform%2Fkernel%2Flinux-starfive.git

nvme-tcp: fix possible leakage during error flow

During nvme_tcp_setup_cmd_pdu error flow, one must call nvme_cleanup_cmd
since it's symmetric to nvme_setup_cmd.

Signed-off-by: Max Gurtovoy <maxg@mellanox.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Keith Busch <kbusch@kernel.org>
---

diff --git a/drivers/nvme/host/tcp.c b/drivers/nvme/host/tcp.c
index 820dac1..770dbcbc 100644
--- a/drivers/nvme/host/tcp.c
+++ b/drivers/nvme/host/tcp.c
@@ -2136,6 +2136,7 @@ static blk_status_t nvme_tcp_setup_cmd_pdu(struct nvme_ns *ns,
 
 	ret = nvme_tcp_map_data(queue, rq);
 	if (unlikely(ret)) {
+		nvme_cleanup_cmd(rq);
 		dev_err(queue->ctrl->ctrl.device,
 			"Failed to map data (%d)\n", ret);
 		return ret;