From: Joonsoo Kim Date: Wed, 12 Dec 2012 21:51:53 +0000 (-0800) Subject: mm: WARN_ON_ONCE if f_op->mmap() change vma's start address X-Git-Tag: upstream/snapshot3+hdmi~6084^2~21 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=2897b4d29d9fca82a57b09b8a216a5d604966e4b;p=platform%2Fadaptation%2Frenesas_rcar%2Frenesas_kernel.git mm: WARN_ON_ONCE if f_op->mmap() change vma's start address During reviewing the source code, I found a comment which mention that after f_op->mmap(), vma's start address can be changed. I didn't verify that it is really possible, because there are so many f_op->mmap() implementation. But if there are some mmap() which change vma's start address, it is possible error situation, because we already prepare prev vma, rb_link and rb_parent and these are related to original address. So add WARN_ON_ONCE for finding that this situtation really happens. Signed-off-by: Joonsoo Kim Signed-off-by: Andrew Morton Signed-off-by: Linus Torvalds --- diff --git a/mm/mmap.c b/mm/mmap.c index f940062..9ed3a06 100644 --- a/mm/mmap.c +++ b/mm/mmap.c @@ -1488,7 +1488,11 @@ munmap_back: * * Answer: Yes, several device drivers can do it in their * f_op->mmap method. -DaveM + * Bug: If addr is changed, prev, rb_link, rb_parent should + * be updated for vma_link() */ + WARN_ON_ONCE(addr != vma->vm_start); + addr = vma->vm_start; pgoff = vma->vm_pgoff; vm_flags = vma->vm_flags;