From: Piotr Kosko <p.kosko@samsung.com>
Date: Wed, 1 Apr 2020 11:25:38 +0000 (+0200)
Subject: [Bookmark] Added deprecation warnings
X-Git-Tag: submit/tizen/20200508.122743~4^2
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=285d864af35278a96a937e06a8b2499265508164;p=platform%2Fcore%2Fapi%2Fwebapi-plugins.git

[Bookmark] Added deprecation warnings

Whole module is deprecated since 6.0 - added warnings for C++ and JS
layers.

[ACR] https://code.sec.samsung.net/jira/browse/TWDAPI-257

[Verification] Code compiles without errors.

Change-Id: Iea2fb030b2876e0546273adf17b0f6e7c43ec296
---

diff --git a/src/bookmark/bookmark_api.js b/src/bookmark/bookmark_api.js
index 8e9513f1..6e38b603 100755
--- a/src/bookmark/bookmark_api.js
+++ b/src/bookmark/bookmark_api.js
@@ -17,6 +17,7 @@
 var validator_ = xwalk.utils.validator;
 var types_ = validator_.Types;
 var native_ = new xwalk.utils.NativeManager(extension);
+var privUtils_ = xwalk.utils;
 
 function EditManager() {
     this.canEdit = false;
@@ -35,6 +36,7 @@ var _edit = new EditManager();
 function BookmarkManager() {}
 
 BookmarkManager.prototype.get = function() {
+    privUtils_.printDeprecationWarningFor('Bookmark API');
     var args = validator_.validateArgs(arguments, [
         {
             name: 'parentFolder',
@@ -66,6 +68,7 @@ BookmarkManager.prototype.get = function() {
 };
 
 BookmarkManager.prototype.add = function() {
+    privUtils_.printDeprecationWarningFor('Bookmark API');
     var args = validator_.validateArgs(arguments, [
         {
             name: 'bookmark',
@@ -98,6 +101,7 @@ BookmarkManager.prototype.add = function() {
 };
 
 BookmarkManager.prototype.remove = function() {
+    privUtils_.printDeprecationWarningFor('Bookmark API');
     var args = validator_.validateArgs(arguments, [
         {
             name: 'bookmark',
@@ -136,6 +140,7 @@ BookmarkManager.prototype.remove = function() {
 function BookmarkProvider() {}
 
 BookmarkProvider.prototype.addToFolder = function() {
+    privUtils_.printDeprecationWarningFor('Bookmark API');
     var args = validator_.validateArgs(arguments, [
         {
             name: 'bookmark',
@@ -170,6 +175,7 @@ BookmarkProvider.prototype.addToFolder = function() {
 };
 
 BookmarkProvider.prototype.getFolder = function() {
+    privUtils_.printDeprecationWarningFor('Bookmark API');
     var args = validator_.validateArgs(arguments, [
         {
             name: 'id',
@@ -202,6 +208,7 @@ BookmarkProvider.prototype.getFolder = function() {
 };
 
 BookmarkProvider.prototype.getFolderItems = function() {
+    privUtils_.printDeprecationWarningFor('Bookmark API');
     var args = validator_.validateArgs(arguments, [
         {
             name: 'id',
@@ -253,6 +260,7 @@ BookmarkProvider.prototype.getFolderItems = function() {
 };
 
 BookmarkProvider.prototype.getRootId = function() {
+    privUtils_.printDeprecationWarningFor('Bookmark API');
     var ret = native_.callSync('BookmarkGetRootId');
     if (native_.isFailure(ret)) {
         throw native_.getErrorObject(ret);
@@ -264,6 +272,7 @@ BookmarkProvider.prototype.getRootId = function() {
 var provider = new BookmarkProvider();
 
 tizen.BookmarkItem = function() {
+    privUtils_.printDeprecationWarningFor('Bookmark API');
     validator_.isConstructorCall(this, tizen.BookmarkItem);
     var args = validator_.validateArgs(arguments, [
         {
@@ -320,6 +329,7 @@ tizen.BookmarkItem = function() {
 };
 
 tizen.BookmarkFolder = function() {
+    privUtils_.printDeprecationWarningFor('Bookmark API');
     validator_.isConstructorCall(this, tizen.BookmarkFolder);
     var args = validator_.validateArgs(arguments, [
         {
diff --git a/src/bookmark/bookmark_instance.cc b/src/bookmark/bookmark_instance.cc
index 63402943..eefb2e89 100644
--- a/src/bookmark/bookmark_instance.cc
+++ b/src/bookmark/bookmark_instance.cc
@@ -26,6 +26,7 @@
 
 using common::ErrorCode;
 using common::PlatformResult;
+using namespace common::tools;
 
 namespace extension {
 namespace bookmark {
@@ -184,6 +185,7 @@ PlatformResult BookmarkInstance::BookmarkTitleExistsInParent(const char* title,
 
 void BookmarkInstance::BookmarkGet(const picojson::value& arg, picojson::object& o) {
   ScopeLogger();
+  PrintDeprecationWarningFor("Bookmark API");
   CHECK_PRIVILEGE_ACCESS(kPrivilegeBookmarkRead, &o);
 
   Context ctx = {0};
@@ -215,6 +217,7 @@ void BookmarkInstance::BookmarkGet(const picojson::value& arg, picojson::object&
 
 void BookmarkInstance::BookmarkAdd(const picojson::value& arg, picojson::object& o) {
   ScopeLogger();
+  PrintDeprecationWarningFor("Bookmark API");
   CHECK_PRIVILEGE_ACCESS(kPrivilegeBookmarkWrite, &o);
 
   const auto& title = arg.get(kTitle).get<std::string>();
@@ -284,6 +287,7 @@ void BookmarkInstance::BookmarkAdd(const picojson::value& arg, picojson::object&
 
 void BookmarkInstance::BookmarkRemove(const picojson::value& arg, picojson::object& o) {
   ScopeLogger();
+  PrintDeprecationWarningFor("Bookmark API");
   CHECK_PRIVILEGE_ACCESS(kPrivilegeBookmarkWrite, &o);
 
   int id = common::stol(common::FromJson<std::string>(arg.get<picojson::object>(), kId));
@@ -298,6 +302,7 @@ void BookmarkInstance::BookmarkRemove(const picojson::value& arg, picojson::obje
 
 void BookmarkInstance::BookmarkRemoveAll(const picojson::value& msg, picojson::object& o) {
   ScopeLogger();
+  PrintDeprecationWarningFor("Bookmark API");
   CHECK_PRIVILEGE_ACCESS(kPrivilegeBookmarkWrite, &o);
 
   int ntv_ret = bp_bookmark_adaptor_reset();
@@ -310,6 +315,7 @@ void BookmarkInstance::BookmarkRemoveAll(const picojson::value& msg, picojson::o
 
 void BookmarkInstance::BookmarkGetRootId(const picojson::value& msg, picojson::object& o) {
   ScopeLogger();
+  PrintDeprecationWarningFor("Bookmark API");
   int rootId(0);
   int ntv_ret = bp_bookmark_adaptor_get_root(&rootId);
   if (ntv_ret < 0) {