From: Jehan Date: Wed, 4 Sep 2013 01:04:47 +0000 (+1200) Subject: Bug 707131 - removing useless test. X-Git-Tag: 1.36.0~4 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=285be5bd7ee3ce87bb027b405be674d6f91995d1;p=platform%2Fupstream%2Fpango.git Bug 707131 - removing useless test. Since pango_scan_int() would return FALSE if the scanned value was over INT_MAX; and the reference out value's type is an int, (n > INT_MAX) test is unecessary. If pango_scan_int() behavior was to be changed to accept long int, an explicit test should be added (or the PangoAttrSize type updated to handle long int too). --- diff --git a/pango/pango-markup.c b/pango/pango-markup.c index 2b2c304..c96c29e 100644 --- a/pango/pango-markup.c +++ b/pango/pango-markup.c @@ -1190,7 +1190,7 @@ span_parse_func (MarkupData *md G_GNUC_UNUSED, const char *end; gint n; - if ((end = size, !pango_scan_int (&end, &n)) || *end != '\0' || n < 0 || n > INT_MAX) + if ((end = size, !pango_scan_int (&end, &n)) || *end != '\0' || n < 0) { g_set_error (error, G_MARKUP_ERROR,