From: Karol Herbst <kherbst@redhat.com>
Date: Fri, 20 Sep 2019 10:43:10 +0000 (+0200)
Subject: clover/llvm: remove harmful std::move call
X-Git-Tag: upstream/19.3.0~1660
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=2859c49f7b229db4a37b7c10fab739dbc96922cd;p=platform%2Fupstream%2Fmesa.git

clover/llvm: remove harmful std::move call

both clang and gcc warn with:
"moving a local object in a return statement prevents copy elision"

Signed-off-by: Karol Herbst <kherbst@redhat.com>
Reviewed-by: Pierre Moreau <dev@pmoreau.org>
---

diff --git a/src/gallium/state_trackers/clover/llvm/invocation.cpp b/src/gallium/state_trackers/clover/llvm/invocation.cpp
index d71ddf8..bef334c 100644
--- a/src/gallium/state_trackers/clover/llvm/invocation.cpp
+++ b/src/gallium/state_trackers/clover/llvm/invocation.cpp
@@ -376,7 +376,7 @@ namespace {
             throw build_error();
       }
 
-      return std::move(mod);
+      return mod;
    }
 }