From: Dan Carpenter Date: Wed, 12 Jun 2013 21:05:00 +0000 (-0700) Subject: drivers/misc/sgi-gru/grufile.c: fix info leak in gru_get_config_info() X-Git-Tag: upstream/snapshot3+hdmi~4938^2~7 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=282c4c0ecce9b9ac1b69acae32a4239441601405;p=platform%2Fadaptation%2Frenesas_rcar%2Frenesas_kernel.git drivers/misc/sgi-gru/grufile.c: fix info leak in gru_get_config_info() The "info.fill" array isn't initialized so it can leak uninitialized stack information to user space. Signed-off-by: Dan Carpenter Acked-by: Robin Holt Acked-by: Dimitri Sivanich Signed-off-by: Andrew Morton Signed-off-by: Linus Torvalds --- diff --git a/drivers/misc/sgi-gru/grufile.c b/drivers/misc/sgi-gru/grufile.c index 44d273c..0535d1e 100644 --- a/drivers/misc/sgi-gru/grufile.c +++ b/drivers/misc/sgi-gru/grufile.c @@ -172,6 +172,7 @@ static long gru_get_config_info(unsigned long arg) nodesperblade = 2; else nodesperblade = 1; + memset(&info, 0, sizeof(info)); info.cpus = num_online_cpus(); info.nodes = num_online_nodes(); info.blades = info.nodes / nodesperblade;