From: Tobias Waldekranz Date: Wed, 21 Apr 2021 12:04:53 +0000 (+0200) Subject: net: dsa: mv88e6xxx: Fix off-by-one in VTU devlink region size X-Git-Tag: accepted/tizen/unified/20230118.172025~7335^2~76^2~1 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=281140a0a2ce4febf2c0ce5d29d0e7d961a826b1;p=platform%2Fkernel%2Flinux-rpi.git net: dsa: mv88e6xxx: Fix off-by-one in VTU devlink region size In the unlikely event of the VTU being loaded to the brim with 4k entries, the last one was placed in the buffer, but the size reported to devlink was off-by-one. Make sure that the final entry is available to the caller. Fixes: ca4d632aef03 ("net: dsa: mv88e6xxx: Export VTU as devlink region") Signed-off-by: Tobias Waldekranz Reviewed-by: Andrew Lunn Signed-off-by: David S. Miller --- diff --git a/drivers/net/dsa/mv88e6xxx/devlink.c b/drivers/net/dsa/mv88e6xxx/devlink.c index 21953d6..ada7a38 100644 --- a/drivers/net/dsa/mv88e6xxx/devlink.c +++ b/drivers/net/dsa/mv88e6xxx/devlink.c @@ -678,7 +678,7 @@ static int mv88e6xxx_setup_devlink_regions_global(struct dsa_switch *ds, sizeof(struct mv88e6xxx_devlink_atu_entry); break; case MV88E6XXX_REGION_VTU: - size = mv88e6xxx_max_vid(chip) * + size = (mv88e6xxx_max_vid(chip) + 1) * sizeof(struct mv88e6xxx_devlink_vtu_entry); break; }