From: Stuart Hayes Date: Wed, 4 Oct 2017 15:57:52 +0000 (-0500) Subject: PCI: Create SR-IOV virtfn/physfn links before attaching driver X-Git-Tag: v5.15~9999^2~15^2~5 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=27d6162944b9b34c32cd5841acd21786637ee743;p=platform%2Fkernel%2Flinux-starfive.git PCI: Create SR-IOV virtfn/physfn links before attaching driver When creating virtual functions, create the "virtfn%u" and "physfn" links in sysfs *before* attaching the driver instead of after. When we attach the driver to the new virtual network interface first, there is a race when the driver attaches to the new sends out an "add" udev event, and the network interface naming software (biosdevname or systemd, for example) tries to look at these links. Signed-off-by: Stuart Hayes Signed-off-by: Bjorn Helgaas --- diff --git a/drivers/pci/iov.c b/drivers/pci/iov.c index 7492a65..ce24cf2 100644 --- a/drivers/pci/iov.c +++ b/drivers/pci/iov.c @@ -159,7 +159,6 @@ int pci_iov_add_virtfn(struct pci_dev *dev, int id) pci_device_add(virtfn, virtfn->bus); - pci_bus_add_device(virtfn); sprintf(buf, "virtfn%u", id); rc = sysfs_create_link(&dev->dev.kobj, &virtfn->dev.kobj, buf); if (rc) @@ -170,6 +169,8 @@ int pci_iov_add_virtfn(struct pci_dev *dev, int id) kobject_uevent(&virtfn->dev.kobj, KOBJ_CHANGE); + pci_bus_add_device(virtfn); + return 0; failed2: