From: Markus Elfring Date: Fri, 6 Nov 2015 17:00:30 +0000 (+0100) Subject: HID: wacom: Delete an unnecessary check before kobject_put() X-Git-Tag: v4.14-rc1~4016^2^10~14 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=27ba1d56e1e150294802f0dca8368abc51a664fb;p=platform%2Fkernel%2Flinux-rpi.git HID: wacom: Delete an unnecessary check before kobject_put() The kobject_put() function tests whether its argument is NULL and then returns immediately. Thus the test around the call is not needed. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring Signed-off-by: Jiri Kosina --- diff --git a/drivers/hid/wacom_sys.c b/drivers/hid/wacom_sys.c index e06af5b..c7a3b79 100644 --- a/drivers/hid/wacom_sys.c +++ b/drivers/hid/wacom_sys.c @@ -1353,8 +1353,7 @@ static void wacom_clean_inputs(struct wacom *wacom) else input_free_device(wacom->wacom_wac.pad_input); } - if (wacom->remote_dir) - kobject_put(wacom->remote_dir); + kobject_put(wacom->remote_dir); wacom->wacom_wac.pen_input = NULL; wacom->wacom_wac.touch_input = NULL; wacom->wacom_wac.pad_input = NULL;