From: Dmitry Osipenko Date: Thu, 20 Oct 2022 21:33:35 +0000 (+0300) Subject: drm/client: Switch drm_client_buffer_delete() to unlocked drm_gem_vunmap X-Git-Tag: v6.6.17~3937^2~23^2~1463 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=27b2ae654370e1a8e446b0e48c4e406abed12ca1;p=platform%2Fkernel%2Flinux-rpi.git drm/client: Switch drm_client_buffer_delete() to unlocked drm_gem_vunmap The drm_client_buffer_delete() wasn't switched to unlocked GEM vunmapping by accident when rest of drm_client code transitioned to the unlocked variants of the vmapping functions. Make drm_client_buffer_delete() use the unlocked variant. This fixes lockdep warning splat about missing reservation lock when framebuffer is released. Reported-by: kernel test robot Link: https://lore.kernel.org/dri-devel/890f70db-68b0-8456-ca3c-c5496ef90517@collabora.com/T/ Fixes: 79e2cf2e7a19 ("drm/gem: Take reservation lock for vmap/vunmap operations") Signed-off-by: Dmitry Osipenko Acked-by: Christian König Link: https://patchwork.freedesktop.org/patch/msgid/20221020213335.309092-1-dmitry.osipenko@collabora.com --- diff --git a/drivers/gpu/drm/drm_client.c b/drivers/gpu/drm/drm_client.c index fbcb1e9..38e1be9 100644 --- a/drivers/gpu/drm/drm_client.c +++ b/drivers/gpu/drm/drm_client.c @@ -235,7 +235,7 @@ static void drm_client_buffer_delete(struct drm_client_buffer *buffer) { struct drm_device *dev = buffer->client->dev; - drm_gem_vunmap(buffer->gem, &buffer->map); + drm_gem_vunmap_unlocked(buffer->gem, &buffer->map); if (buffer->gem) drm_gem_object_put(buffer->gem);