From: GONG, Ruiqi <gongruiqi1@huawei.com>
Date: Wed, 6 Apr 2022 11:46:29 +0000 (+0800)
Subject: net: mpls: fix memdup.cocci warning
X-Git-Tag: v6.6.17~7459^2~373
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=27a5a5685d373cd8c18b1d83f42a83e5a2f93e6c;p=platform%2Fkernel%2Flinux-rpi.git

net: mpls: fix memdup.cocci warning

Simply use kmemdup instead of explicitly allocating and copying memory.

Generated by: scripts/coccinelle/api/memdup.cocci

Signed-off-by: GONG, Ruiqi <gongruiqi1@huawei.com>
Link: https://lore.kernel.org/r/20220406114629.182833-1-gongruiqi1@huawei.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
---

diff --git a/net/mpls/af_mpls.c b/net/mpls/af_mpls.c
index d6fdc57..35b5f80 100644
--- a/net/mpls/af_mpls.c
+++ b/net/mpls/af_mpls.c
@@ -1527,10 +1527,9 @@ static int mpls_ifdown(struct net_device *dev, int event)
 					rt->rt_nh_size;
 				struct mpls_route *orig = rt;
 
-				rt = kmalloc(size, GFP_KERNEL);
+				rt = kmemdup(orig, size, GFP_KERNEL);
 				if (!rt)
 					return -ENOMEM;
-				memcpy(rt, orig, size);
 			}
 		}