From: David Howells Date: Tue, 2 Sep 2014 12:52:20 +0000 (+0100) Subject: KEYS: Fix use-after-free in assoc_array_gc() X-Git-Tag: v5.15~17301^2~1 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=27419604f51a97d497853f14142c1059d46eb597;p=platform%2Fkernel%2Flinux-starfive.git KEYS: Fix use-after-free in assoc_array_gc() An edit script should be considered inaccessible by a function once it has called assoc_array_apply_edit() or assoc_array_cancel_edit(). However, assoc_array_gc() is accessing the edit script just after the gc_complete: label. Reported-by: Andreea-Cristina Bernat Signed-off-by: David Howells Reviewed-by: Andreea-Cristina Bernat cc: shemming@brocade.com cc: paulmck@linux.vnet.ibm.com Cc: stable@vger.kernel.org Signed-off-by: James Morris --- diff --git a/lib/assoc_array.c b/lib/assoc_array.c index c0b1007..ae146f0 100644 --- a/lib/assoc_array.c +++ b/lib/assoc_array.c @@ -1735,7 +1735,7 @@ ascend_old_tree: gc_complete: edit->set[0].to = new_root; assoc_array_apply_edit(edit); - edit->array->nr_leaves_on_tree = nr_leaves_on_tree; + array->nr_leaves_on_tree = nr_leaves_on_tree; return 0; enomem: