From: Patrick Mochel Date: Mon, 20 Jun 2005 22:15:28 +0000 (-0700) Subject: [PATCH] usb: klist_node_attached() fix X-Git-Tag: v2.6.13-rc4~130^2~203^2^2~28 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=273971bade8a6d37c1b162146de1a53965cdc245;p=profile%2Fivi%2Fkernel-adaptation-intel-automotive.git [PATCH] usb: klist_node_attached() fix The original code looks like this: /* if interface was already added, bind now; else let * the future device_add() bind it, bypassing probe() */ if (!list_empty (&dev->bus_list)) device_bind_driver(dev); IOW, it's checking to see if the device is attached to the bus or not and binding the driver if it is. It's checking the device's bus list, which will only appear empty when the device has been initialized, but not added. It depends way too much on the driver model internals, but it seems to be the only way to do the weird crap they want to do with interfaces. When I converted it to use klists, I accidentally inverted the logic, which led to bad things happening. This patch returns the check to its orginal value. From: Patrick Mochel Signed-off-by: Andrew Morton Signed-off-by: Greg Kroah-Hartman Index: gregkh-2.6/drivers/usb/core/usb.c =================================================================== --- diff --git a/drivers/usb/core/usb.c b/drivers/usb/core/usb.c index 230839a..6667876 100644 --- a/drivers/usb/core/usb.c +++ b/drivers/usb/core/usb.c @@ -293,7 +293,7 @@ int usb_driver_claim_interface(struct usb_driver *driver, /* if interface was already added, bind now; else let * the future device_add() bind it, bypassing probe() */ - if (!klist_node_attached (&dev->knode_bus)) + if (klist_node_attached(&dev->knode_bus)) device_bind_driver(dev); return 0;