From: Dan Carpenter <dan.carpenter@oracle.com>
Date: Wed, 7 Jul 2021 10:01:00 +0000 (+0300)
Subject: sock: unlock on error in sock_setsockopt()
X-Git-Tag: accepted/tizen/unified/20230118.172025~6815^2~33
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=271dbc31843244e5192f0f8a8be0da26995f944a;p=platform%2Fkernel%2Flinux-rpi.git

sock: unlock on error in sock_setsockopt()

If copy_from_sockptr() then we need to unlock before returning.

Fixes: d463126e23f1 ("net: sock: extend SO_TIMESTAMPING for PHC binding")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
---

diff --git a/net/core/sock.c b/net/core/sock.c
index 1c4b046..a3eea6e 100644
--- a/net/core/sock.c
+++ b/net/core/sock.c
@@ -1123,8 +1123,10 @@ set_sndbuf:
 	case SO_TIMESTAMPING_OLD:
 		if (optlen == sizeof(timestamping)) {
 			if (copy_from_sockptr(&timestamping, optval,
-					      sizeof(timestamping)))
-				return -EFAULT;
+					      sizeof(timestamping))) {
+				ret = -EFAULT;
+				break;
+			}
 		} else {
 			memset(&timestamping, 0, sizeof(timestamping));
 			timestamping.flags = val;