From: Tim-Philipp Müller <tim@centricular.com>
Date: Fri, 1 May 2020 13:43:55 +0000 (+0100)
Subject: autoconvert: fix compiler warnings with g_atomic on recent GLib versions
X-Git-Tag: 1.19.3~507^2~1946
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=270f2f83a1fd320f3a436a78a30a53dacf09e0b6;p=platform%2Fupstream%2Fgstreamer.git

autoconvert: fix compiler warnings with g_atomic on recent GLib versions

The volatile is not needed here and causes compiler warnings
with newer GLib versions.

gstautoconvert.c: In function ‘gst_auto_convert_dispose’ (and elsewhere):
glib/gatomic.h:108:3: warning: initialization discards ‘volatile’ qualifier from pointer target type [-Wdiscarded-qualifiers]
gstautoconvert.c:224:24: note: in expansion of macro ‘g_atomic_pointer_get’
  224 |     GList *factories = g_atomic_pointer_get (&autoconvert->factories);

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1237>
---

diff --git a/gst/autoconvert/gstautoconvert.h b/gst/autoconvert/gstautoconvert.h
index ae40e63..eaa4f02 100644
--- a/gst/autoconvert/gstautoconvert.h
+++ b/gst/autoconvert/gstautoconvert.h
@@ -41,7 +41,7 @@ struct _GstAutoConvert
   /*< private >*/
   GstBin bin;                   /* we extend GstBin */
 
-  volatile GList *factories;
+  GList *factories;
 
   GstPad *sinkpad;
   GstPad *srcpad;