From: Pablo Neira Ayuso <pablo@netfilter.org>
Date: Mon, 29 Apr 2019 09:54:56 +0000 (+0200)
Subject: netfilter: nft_flow_offload: add entry to flowtable after confirmation
X-Git-Tag: v5.4-rc1~1003^2~7^2~11
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=270a8a297f42ecff82060aaa53118361f09c1f7d;p=platform%2Fkernel%2Flinux-rpi.git

netfilter: nft_flow_offload: add entry to flowtable after confirmation

This is fixing flow offload for UDP traffic where packets only follow
one single direction.

The flow_offload_fixup_tcp() mechanism works fine in case that the
offloaded entry remains in SYN_RECV state, given sequence tracking is
reset and that conntrack handles syn+ack packets as a retransmission, ie.

	sES + synack => sIG

for reply traffic.

Fixes: a3c90f7a2323 ("netfilter: nf_tables: flow offload expression")
Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
---

diff --git a/net/netfilter/nft_flow_offload.c b/net/netfilter/nft_flow_offload.c
index 6e6b9ad..8968c7f 100644
--- a/net/netfilter/nft_flow_offload.c
+++ b/net/netfilter/nft_flow_offload.c
@@ -94,8 +94,7 @@ static void nft_flow_offload_eval(const struct nft_expr *expr,
 	if (help)
 		goto out;
 
-	if (ctinfo == IP_CT_NEW ||
-	    ctinfo == IP_CT_RELATED)
+	if (!nf_ct_is_confirmed(ct))
 		goto out;
 
 	if (test_and_set_bit(IPS_OFFLOAD_BIT, &ct->status))