From: Mark Nauwelaerts <mnauw@users.sourceforge.net>
Date: Sun, 21 Apr 2019 15:17:14 +0000 (+0200)
Subject: srt: post error when failing to start
X-Git-Tag: 1.16.2~92
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=26bd240a59cb2ab5291e78f0a858110435d4e168;p=platform%2Fupstream%2Fgst-plugins-bad.git

srt: post error when failing to start

... as appropriate for a subsequent state change failure
---

diff --git a/ext/srt/gstsrtsink.c b/ext/srt/gstsrtsink.c
index 074bd0f16..bd8159d26 100644
--- a/ext/srt/gstsrtsink.c
+++ b/ext/srt/gstsrtsink.c
@@ -155,7 +155,9 @@ gst_srt_sink_start (GstBaseSink * bsink)
   }
 
   if (!ret) {
-    GST_WARNING_OBJECT (self, "Failed to open SRT: %s", error->message);
+    /* ensure error is posted since state change will fail */
+    GST_ELEMENT_ERROR (self, RESOURCE, OPEN_WRITE, (NULL),
+        ("Failed to open SRT: %s", error->message));
     g_clear_error (&error);
   }
 
diff --git a/ext/srt/gstsrtsrc.c b/ext/srt/gstsrtsrc.c
index cfaa7ba70..73392b4c2 100644
--- a/ext/srt/gstsrtsrc.c
+++ b/ext/srt/gstsrtsrc.c
@@ -114,7 +114,9 @@ gst_srt_src_start (GstBaseSrc * bsrc)
   }
 
   if (!ret) {
-    GST_WARNING_OBJECT (self, "Failed to open SRT: %s", error->message);
+    /* ensure error is posted since state change will fail */
+    GST_ELEMENT_ERROR (self, RESOURCE, OPEN_READ, (NULL),
+        ("Failed to open SRT: %s", error->message));
     g_clear_error (&error);
   }