From: Mugilraj Dhavachelvan Date: Sun, 14 Mar 2021 17:57:09 +0000 (+0530) Subject: iio:dac:max517.c: Use devm_iio_device_register() X-Git-Tag: accepted/tizen/unified/20230118.172025~7414^2~344^2~12 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=2662e81745fc00cafcbbb532018013607cae84e0;p=platform%2Fkernel%2Flinux-rpi.git iio:dac:max517.c: Use devm_iio_device_register() Use devm_iio_device_register() to avoid remove function and drop explicit call to iio_device_unregister(). Signed-off-by: Mugilraj Dhavachelvan Reviewed-by: Lars-Peter Clausen Link: https://lore.kernel.org/r/20210314175709.34301-1-dmugil2000@gmail.com Signed-off-by: Jonathan Cameron --- diff --git a/drivers/iio/dac/max517.c b/drivers/iio/dac/max517.c index daa6038..a6ef555 100644 --- a/drivers/iio/dac/max517.c +++ b/drivers/iio/dac/max517.c @@ -153,7 +153,6 @@ static int max517_probe(struct i2c_client *client, if (!indio_dev) return -ENOMEM; data = iio_priv(indio_dev); - i2c_set_clientdata(client, indio_dev); data->client = client; switch (id->driver_data) { @@ -186,13 +185,7 @@ static int max517_probe(struct i2c_client *client, data->vref_mv[chan] = platform_data->vref_mv[chan]; } - return iio_device_register(indio_dev); -} - -static int max517_remove(struct i2c_client *client) -{ - iio_device_unregister(i2c_get_clientdata(client)); - return 0; + return devm_iio_device_register(&client->dev, indio_dev); } static const struct i2c_device_id max517_id[] = { @@ -211,7 +204,6 @@ static struct i2c_driver max517_driver = { .pm = &max517_pm_ops, }, .probe = max517_probe, - .remove = max517_remove, .id_table = max517_id, }; module_i2c_driver(max517_driver);