From: Dave Airlie <airlied@redhat.com>
Date: Tue, 18 May 2010 09:00:14 +0000 (+1000)
Subject: drm/radeon/pm: fix device_create_file return value checks.
X-Git-Tag: v2.6.35-rc1~18^2~20
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=26481fb15644b5fd85d4cea020f74a234cdf6803;p=platform%2Fkernel%2Flinux-stable.git

drm/radeon/pm: fix device_create_file return value checks.

print an error if these fail.

Signed-off-by: Dave Airlie <airlied@redhat.com>
---

diff --git a/drivers/gpu/drm/radeon/radeon_pm.c b/drivers/gpu/drm/radeon/radeon_pm.c
index c88edae..a8d162c 100644
--- a/drivers/gpu/drm/radeon/radeon_pm.c
+++ b/drivers/gpu/drm/radeon/radeon_pm.c
@@ -398,6 +398,7 @@ void radeon_pm_resume(struct radeon_device *rdev)
 
 int radeon_pm_init(struct radeon_device *rdev)
 {
+	int ret;
 	/* default to profile method */
 	rdev->pm.pm_method = PM_METHOD_PROFILE;
 	rdev->pm.dynpm_state = DYNPM_STATE_DISABLED;
@@ -427,8 +428,12 @@ int radeon_pm_init(struct radeon_device *rdev)
 		}
 
 		/* where's the best place to put these? */
-		device_create_file(rdev->dev, &dev_attr_power_profile);
-		device_create_file(rdev->dev, &dev_attr_power_method);
+		ret = device_create_file(rdev->dev, &dev_attr_power_profile);
+		if (ret)
+			DRM_ERROR("failed to create device file for power profile\n");
+		ret = device_create_file(rdev->dev, &dev_attr_power_method);
+		if (ret)
+			DRM_ERROR("failed to create device file for power method\n");
 
 #ifdef CONFIG_ACPI
 		rdev->acpi_nb.notifier_call = radeon_acpi_event;