From: Greg Kroah-Hartman Date: Tue, 24 Mar 2015 19:06:41 +0000 (+0100) Subject: greybus: es1: no need to check for NULL on debugfs_remove() X-Git-Tag: v5.15~12752^2~378^2~21^2~1651^2~6 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=26164edb8fb467a4249fab159709a6cfc50ddc8c;p=platform%2Fkernel%2Flinux-starfive.git greybus: es1: no need to check for NULL on debugfs_remove() The function can, and even expects NULL, so don't check. Signed-off-by: Greg Kroah-Hartman --- diff --git a/drivers/staging/greybus/es1.c b/drivers/staging/greybus/es1.c index cce3155..723d8b7 100644 --- a/drivers/staging/greybus/es1.c +++ b/drivers/staging/greybus/es1.c @@ -558,10 +558,8 @@ static void usb_log_enable(struct es1_ap_dev *es1, int enable) gb_debugfs_get(), NULL, &apb1_log_fops); } else { - if (apb1_log_dentry) { - debugfs_remove(apb1_log_dentry); - apb1_log_dentry = NULL; - } + debugfs_remove(apb1_log_dentry); + apb1_log_dentry = NULL; if (apb1_log_task) { kthread_stop(apb1_log_task);