From: Tom Stellard Date: Thu, 7 Feb 2013 19:39:38 +0000 (+0000) Subject: R600/SI: add proper 64bit immediate support v2 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=26075d58a241c633739bf78dff90856bcbf992df;p=platform%2Fupstream%2Fllvm.git R600/SI: add proper 64bit immediate support v2 v2: rebased on current upstream Patch by: Christian König Signed-off-by: Christian König Reviewed-by: Tom Stellard llvm-svn: 174652 --- diff --git a/llvm/lib/Target/R600/SIInstrInfo.td b/llvm/lib/Target/R600/SIInstrInfo.td index 9d9f5f6..83ee2cf 100644 --- a/llvm/lib/Target/R600/SIInstrInfo.td +++ b/llvm/lib/Target/R600/SIInstrInfo.td @@ -38,6 +38,16 @@ def SIvcc_bitcast : SDNode<"SIISD::VCC_BITCAST", SDTypeProfile<1, 1, [SDTCisInt<0>, SDTCisInt<1>]> >; +// Transformation function, extract the lower 32bit of a 64bit immediate +def LO32 : SDNodeXFormgetTargetConstant(N->getZExtValue() & 0xffffffff, MVT::i32); +}]>; + +// Transformation function, extract the upper 32bit of a 64bit immediate +def HI32 : SDNodeXFormgetTargetConstant(N->getZExtValue() >> 32, MVT::i32); +}]>; + class InstSI pattern> : AMDGPUInst { diff --git a/llvm/lib/Target/R600/SIInstructions.td b/llvm/lib/Target/R600/SIInstructions.td index dd5bb42..7d35561 100644 --- a/llvm/lib/Target/R600/SIInstructions.td +++ b/llvm/lib/Target/R600/SIInstructions.td @@ -1019,19 +1019,16 @@ def S_MOV_IMM_I32 : InstSI < [(set SReg_32:$dst, (imm:$src0))] >; -// i64 immediates aren't really supported in hardware, but LLVM will use the i64 -// type for indices on load and store instructions. The pattern for -// S_MOV_IMM_I64 will only match i64 immediates that can fit into 32-bits, -// which the hardware can handle. -def S_MOV_IMM_I64 : InstSI < - (outs SReg_64:$dst), - (ins i64imm:$src0), - "S_MOV_IMM_I64 $dst, $src0", - [(set SReg_64:$dst, (IMM32bitIn64bit:$src0))] ->; - } // End isCodeGenOnly, isPseudo = 1 +// i64 immediates aren't supported in hardware, split it into two 32bit values +def : Pat < + (i64 imm:$imm), + (INSERT_SUBREG (INSERT_SUBREG (i64 (IMPLICIT_DEF)), + (S_MOV_IMM_I32 (LO32 imm:$imm)), sub0), + (S_MOV_IMM_I32 (HI32 imm:$imm)), sub1) +>; + class SI_LOAD_LITERAL : Enc32 <(outs), (ins ImmType:$imm), "LOAD_LITERAL $imm", []> { diff --git a/llvm/lib/Target/R600/SILowerLiteralConstants.cpp b/llvm/lib/Target/R600/SILowerLiteralConstants.cpp index c0411e9..6f5fd36 100644 --- a/llvm/lib/Target/R600/SILowerLiteralConstants.cpp +++ b/llvm/lib/Target/R600/SILowerLiteralConstants.cpp @@ -73,7 +73,6 @@ bool SILowerLiteralConstantsPass::runOnMachineFunction(MachineFunction &MF) { switch (MI.getOpcode()) { default: break; case AMDGPU::S_MOV_IMM_I32: - case AMDGPU::S_MOV_IMM_I64: case AMDGPU::V_MOV_IMM_F32: case AMDGPU::V_MOV_IMM_I32: { unsigned MovOpcode;