From: Marek Vasut Date: Sat, 17 Feb 2018 01:16:48 +0000 (+0100) Subject: ARM: rmobile: Fix broken reset code on Porter X-Git-Tag: v2018.03-rc3~9^2 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=25f6dc8955bdf97bfb16ef19de7ce4abe76aaee4;p=platform%2Fkernel%2Fu-boot.git ARM: rmobile: Fix broken reset code on Porter The 'reset' command did not work on Porter because the reset code was accessing the wrong PMIC address over broken I2C bus driver. Replace the code with DM-aware code and fix up the PMIC address. This makes the 'reset' command work again. Signed-off-by: Marek Vasut Cc: Nobuhiro Iwamatsu --- diff --git a/board/renesas/porter/porter.c b/board/renesas/porter/porter.c index dfefd7f..320841f 100644 --- a/board/renesas/porter/porter.c +++ b/board/renesas/porter/porter.c @@ -116,12 +116,25 @@ const struct rmobile_sysinfo sysinfo = { void reset_cpu(ulong addr) { - u8 val; + struct udevice *dev; + const u8 pmic_bus = 6; + const u8 pmic_addr = 0x5a; + u8 data; + int ret; - i2c_set_bus_num(2); /* PowerIC connected to ch2 */ - i2c_read(CONFIG_SYS_I2C_POWERIC_ADDR, 0x13, 1, &val, 1); - val |= 0x02; - i2c_write(CONFIG_SYS_I2C_POWERIC_ADDR, 0x13, 1, &val, 1); + ret = i2c_get_chip_for_busnum(pmic_bus, pmic_addr, 1, &dev); + if (ret) + hang(); + + ret = dm_i2c_read(dev, 0x13, &data, 1); + if (ret) + hang(); + + data |= BIT(1); + + ret = dm_i2c_write(dev, 0x13, &data, 1); + if (ret) + hang(); } #ifdef CONFIG_SPL_BUILD