From: Mike Frysinger <vapier@gentoo.org>
Date: Mon, 6 Dec 2010 21:12:23 +0000 (+0000)
Subject: Blackfin: sram_free_with_lsl: do not ignore return value of sram_free
X-Git-Tag: v3.0~2449^2~2
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=25f3ff2c445822793d22ac51e3dcb22a694e3cd4;p=platform%2Fkernel%2Flinux-amlogic.git

Blackfin: sram_free_with_lsl: do not ignore return value of sram_free

If there was an error in the lower free functions, we need to pass that
back up so the calling process is able to check things.

Signed-off-by: Mike Frysinger <vapier@gentoo.org>
---

diff --git a/arch/blackfin/mm/sram-alloc.c b/arch/blackfin/mm/sram-alloc.c
index 627e04b..dfd304a 100644
--- a/arch/blackfin/mm/sram-alloc.c
+++ b/arch/blackfin/mm/sram-alloc.c
@@ -704,18 +704,18 @@ int sram_free_with_lsl(const void *addr)
 {
 	struct sram_list_struct *lsl, **tmp;
 	struct mm_struct *mm = current->mm;
+	int ret = -1;
 
 	for (tmp = &mm->context.sram_list; *tmp; tmp = &(*tmp)->next)
-		if ((*tmp)->addr == addr)
-			goto found;
-	return -1;
-found:
-	lsl = *tmp;
-	sram_free(addr);
-	*tmp = lsl->next;
-	kfree(lsl);
+		if ((*tmp)->addr == addr) {
+			lsl = *tmp;
+			ret = sram_free(addr);
+			*tmp = lsl->next;
+			kfree(lsl);
+			break;
+		}
 
-	return 0;
+	return ret;
 }
 EXPORT_SYMBOL(sram_free_with_lsl);