From: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Date: Tue, 5 Jul 2022 20:51:39 +0000 (+0200)
Subject: crypto: atmel-sha - Drop if with an always false condition
X-Git-Tag: v6.6.17~6939^2~31
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=25edb4cddb0f3deb260b52106b73c3d0f4968489;p=platform%2Fkernel%2Flinux-rpi.git

crypto: atmel-sha - Drop if with an always false condition

The remove callback is only called after probe completed successfully.
In this case platform_set_drvdata() was called with a non-NULL argument
and so sha_dd is never NULL.

This is a preparation for making platform remove callbacks return void.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Reviewed-by: Claudiu Beznea <claudiu.beznea@microchip.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
---

diff --git a/drivers/crypto/atmel-sha.c b/drivers/crypto/atmel-sha.c
index d1628112dacc..e054e0ac6fc2 100644
--- a/drivers/crypto/atmel-sha.c
+++ b/drivers/crypto/atmel-sha.c
@@ -2669,8 +2669,7 @@ static int atmel_sha_remove(struct platform_device *pdev)
 	struct atmel_sha_dev *sha_dd;
 
 	sha_dd = platform_get_drvdata(pdev);
-	if (!sha_dd)
-		return -ENODEV;
+
 	spin_lock(&atmel_sha.lock);
 	list_del(&sha_dd->list);
 	spin_unlock(&atmel_sha.lock);