From: Min Li Date: Mon, 17 Apr 2023 02:27:54 +0000 (+0800) Subject: Bluetooth: L2CAP: fix "bad unlock balance" in l2cap_disconnect_rsp X-Git-Tag: v6.6.7~2736^2~57^2~9 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=25e97f7b1866e6b8503be349eeea44bb52d661ce;p=platform%2Fkernel%2Flinux-starfive.git Bluetooth: L2CAP: fix "bad unlock balance" in l2cap_disconnect_rsp conn->chan_lock isn't acquired before l2cap_get_chan_by_scid, if l2cap_get_chan_by_scid returns NULL, then 'bad unlock balance' is triggered. Reported-by: syzbot+9519d6b5b79cf7787cf3@syzkaller.appspotmail.com Link: https://lore.kernel.org/all/000000000000894f5f05f95e9f4d@google.com/ Signed-off-by: Min Li Signed-off-by: Luiz Augusto von Dentz --- diff --git a/net/bluetooth/l2cap_core.c b/net/bluetooth/l2cap_core.c index 5cc95fd..376b523 100644 --- a/net/bluetooth/l2cap_core.c +++ b/net/bluetooth/l2cap_core.c @@ -4693,7 +4693,6 @@ static inline int l2cap_disconnect_rsp(struct l2cap_conn *conn, chan = l2cap_get_chan_by_scid(conn, scid); if (!chan) { - mutex_unlock(&conn->chan_lock); return 0; }