From: commit-queue@webkit.org <commit-queue@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Date: Fri, 23 Sep 2011 00:43:07 +0000 (+0000)
Subject: [EFL] Use ewk_view to navigate in history instead of ewk_history.
X-Git-Tag: 070512121124~23847
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=25dd17d0e9069449b02d430a259cf91af3afbfb5;p=profile%2Fivi%2Fwebkit-efl.git

[EFL] Use ewk_view to navigate in history instead of ewk_history.
https://bugs.webkit.org/show_bug.cgi?id=68455

Patch by Raphael Kubo da Costa <kubo@profusion.mobi> on 2011-09-22
Reviewed by Antonio Gomes.

BackForwardItem::invoke() was using ewk_history functions to navigate
in history; however, this will only call WebCore::BackForwardListImpl
and not move between pages at all. We now call ewk_view_navigate and
its siblings to make sure the navigation actually happens.

This should make tests like fast/dom/navigation-type-back-forward.html
stop timing out.

* DumpRenderTree/efl/WorkQueueItemEfl.cpp:
(BackForwardItem::invoke):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95767 268f45cc-cd09-0410-ab3c-d52691b4dbfc
---

diff --git a/Tools/ChangeLog b/Tools/ChangeLog
index 94e7299..dafdd46 100644
--- a/Tools/ChangeLog
+++ b/Tools/ChangeLog
@@ -1,3 +1,21 @@
+2011-09-22  Raphael Kubo da Costa  <kubo@profusion.mobi>
+
+        [EFL] Use ewk_view to navigate in history instead of ewk_history.
+        https://bugs.webkit.org/show_bug.cgi?id=68455
+
+        Reviewed by Antonio Gomes.
+
+        BackForwardItem::invoke() was using ewk_history functions to navigate
+        in history; however, this will only call WebCore::BackForwardListImpl
+        and not move between pages at all. We now call ewk_view_navigate and
+        its siblings to make sure the navigation actually happens.
+
+        This should make tests like fast/dom/navigation-type-back-forward.html
+        stop timing out.
+
+        * DumpRenderTree/efl/WorkQueueItemEfl.cpp:
+        (BackForwardItem::invoke):
+
 2011-09-22  Dean Jackson  <dino@apple.com>
 
         Add ENABLE_CSS_FILTERS
diff --git a/Tools/DumpRenderTree/efl/WorkQueueItemEfl.cpp b/Tools/DumpRenderTree/efl/WorkQueueItemEfl.cpp
index 8eb6577..e7a096d 100644
--- a/Tools/DumpRenderTree/efl/WorkQueueItemEfl.cpp
+++ b/Tools/DumpRenderTree/efl/WorkQueueItemEfl.cpp
@@ -23,6 +23,7 @@
 #include "WorkQueueItem.h"
 
 #include "DumpRenderTree.h"
+#include "DumpRenderTreeChrome.h"
 
 #include <EWebKit.h>
 #include <JavaScriptCore/JSStringRef.h>
@@ -67,16 +68,12 @@ bool ScriptItem::invoke() const
 
 bool BackForwardItem::invoke() const
 {
-    Ewk_History* history = ewk_view_history_get(browser);
-
     if (m_howFar == 1)
-        ewk_history_forward(history);
+        ewk_view_forward(browser->mainView());
     else if (m_howFar == -1)
-        ewk_history_back(history);
-    else {
-        const Ewk_History_Item* item = ewk_history_history_item_nth_get(history, m_howFar);
-        ewk_history_history_item_set(history, item);
-    }
+        ewk_view_back(browser->mainView());
+    else
+        ewk_view_navigate(browser->mainView(), m_howFar);
 
     return true;
 }