From: Edward Hervey <bilboed@bilboed.com>
Date: Mon, 12 May 2014 14:59:29 +0000 (+0200)
Subject: caps: Don't leak features on error cases
X-Git-Tag: 1.3.2~12
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=25bcc2d7f61d56df4e602d3c91e9a25d2ca4771c;p=platform%2Fupstream%2Fgstreamer.git

caps: Don't leak features on error cases

If we fail to parse fields, we would end up leaking the features we
parsed just before

CID #1212152
---

diff --git a/gst/gstcaps.c b/gst/gstcaps.c
index c315e71..b729b79 100644
--- a/gst/gstcaps.c
+++ b/gst/gstcaps.c
@@ -2299,12 +2299,15 @@ gst_caps_from_string_inplace (GstCaps * caps, const gchar * string)
 
     if (!priv_gst_structure_parse_fields (s, &s, structure)) {
       gst_structure_free (structure);
+      if (features)
+        gst_caps_features_free (features);
       g_free (copy);
       return FALSE;
     }
 
   append:
     gst_caps_append_structure_unchecked (caps, structure, features);
+    features = NULL;
     if (*s == '\0')
       break;
   } while (TRUE);