From: Christoph Hellwig <hch@lst.de>
Date: Tue, 23 May 2023 08:40:20 +0000 (+0200)
Subject: btrfs: remove a pointless NULL check in btrfs_lookup_fs_root
X-Git-Tag: v6.6.7~2168^2~143
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=25ac047c9d3df373de35ba4ee3f0c902874a1fab;p=platform%2Fkernel%2Flinux-starfive.git

btrfs: remove a pointless NULL check in btrfs_lookup_fs_root

btrfs_grab_root already checks for a NULL root itself.

Reviewed-by: Johannes Thumshirn <johannes.thumshirn@wdc.com>
Signed-off-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: David Sterba <dsterba@suse.com>
Signed-off-by: David Sterba <dsterba@suse.com>
---

diff --git a/fs/btrfs/disk-io.c b/fs/btrfs/disk-io.c
index c53c82c..06dab9d 100644
--- a/fs/btrfs/disk-io.c
+++ b/fs/btrfs/disk-io.c
@@ -1157,8 +1157,7 @@ static struct btrfs_root *btrfs_lookup_fs_root(struct btrfs_fs_info *fs_info,
 	spin_lock(&fs_info->fs_roots_radix_lock);
 	root = radix_tree_lookup(&fs_info->fs_roots_radix,
 				 (unsigned long)root_id);
-	if (root)
-		root = btrfs_grab_root(root);
+	root = btrfs_grab_root(root);
 	spin_unlock(&fs_info->fs_roots_radix_lock);
 	return root;
 }