From: Dan Carpenter Date: Wed, 25 Sep 2019 10:56:04 +0000 (+0300) Subject: net: broadcom/bcmsysport: Fix signedness in bcm_sysport_probe() X-Git-Tag: v5.4-rc1~14^2~33 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=25a584955f020d6ec499c513923fb220f3112d2b;p=platform%2Fkernel%2Flinux-rpi.git net: broadcom/bcmsysport: Fix signedness in bcm_sysport_probe() The "priv->phy_interface" variable is an enum and in this context GCC will treat it as unsigned so the error handling will never be triggered. Fixes: 80105befdb4b ("net: systemport: add Broadcom SYSTEMPORT Ethernet MAC driver") Signed-off-by: Dan Carpenter Acked-by: Florian Fainelli Signed-off-by: David S. Miller --- diff --git a/drivers/net/ethernet/broadcom/bcmsysport.c b/drivers/net/ethernet/broadcom/bcmsysport.c index 7df887e..a977a45 100644 --- a/drivers/net/ethernet/broadcom/bcmsysport.c +++ b/drivers/net/ethernet/broadcom/bcmsysport.c @@ -2481,7 +2481,7 @@ static int bcm_sysport_probe(struct platform_device *pdev) priv->phy_interface = of_get_phy_mode(dn); /* Default to GMII interface mode */ - if (priv->phy_interface < 0) + if ((int)priv->phy_interface < 0) priv->phy_interface = PHY_INTERFACE_MODE_GMII; /* In the case of a fixed PHY, the DT node associated