From: Johann <johannkoenig@google.com>
Date: Tue, 31 Jan 2017 23:51:15 +0000 (-0800)
Subject: vp8 onyx_if: assert divide by zero
X-Git-Tag: v1.7.0~729
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=25301a84a8fe65f57cfe7d67001912b44f5085c8;p=platform%2Fupstream%2Flibvpx.git

vp8 onyx_if: assert divide by zero

Clears up static clang analysis warning regarding divide by zero.

Trying to explain to the compiler how it's impossible to avoid
incrementing num_blocks at least once is difficult.

Change-Id: Ibaae43be572e5cd7a689b440dcd341c17d33443b
---

diff --git a/vp8/encoder/onyx_if.c b/vp8/encoder/onyx_if.c
index 320a7a7..3790785 100644
--- a/vp8/encoder/onyx_if.c
+++ b/vp8/encoder/onyx_if.c
@@ -43,6 +43,7 @@
 #endif
 #include "encodeframe.h"
 
+#include <assert.h>
 #include <math.h>
 #include <stdio.h>
 #include <limits.h>
@@ -3052,6 +3053,7 @@ static int measure_square_diff_partial(YV12_BUFFER_CONFIG *source,
   }
   // Only return non-zero if we have at least ~1/16 samples for estimate.
   if (num_blocks > (tot_num_blocks >> 4)) {
+    assert(num_blocks != 0);
     return (Total / num_blocks);
   } else {
     return 0;