From: Dan Carpenter Date: Mon, 4 Jan 2016 20:42:55 +0000 (+0300) Subject: drm/amd/powerplay: fix a reversed condition X-Git-Tag: v4.14-rc1~3993^2~13^2~26 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=2500a3c9e06d349defdca00f2efd7fab189ae72f;p=platform%2Fkernel%2Flinux-rpi.git drm/amd/powerplay: fix a reversed condition This test was reversed so it would end up leading to a NULL dereference. Fixes: 4630f0faae80 ('drm/amd/powerplay: add Carrizo smu support') Signed-off-by: Dan Carpenter Signed-off-by: Alex Deucher --- diff --git a/drivers/gpu/drm/amd/powerplay/smumgr/cz_smumgr.c b/drivers/gpu/drm/amd/powerplay/smumgr/cz_smumgr.c index e74023b..873a8d2 100644 --- a/drivers/gpu/drm/amd/powerplay/smumgr/cz_smumgr.c +++ b/drivers/gpu/drm/amd/powerplay/smumgr/cz_smumgr.c @@ -818,7 +818,7 @@ static int cz_smu_fini(struct pp_smumgr *smumgr) return -EINVAL; cz_smu = (struct cz_smumgr *)smumgr->backend; - if (!cz_smu) { + if (cz_smu) { cgs_free_gpu_mem(smumgr->device, cz_smu->toc_buffer.handle); cgs_free_gpu_mem(smumgr->device,