From: Andres Salomon Date: Fri, 22 Jul 2011 03:37:43 +0000 (-0700) Subject: staging: olpc_dcon: remove noinit module variable X-Git-Tag: upstream/snapshot3+hdmi~8929^2^2~864^2~187 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=24e2617050d9ceb2cd8200982249529c81c5f310;p=platform%2Fadaptation%2Frenesas_rcar%2Frenesas_kernel.git staging: olpc_dcon: remove noinit module variable This came from Jordan's original 2007 gxfb_dcon commit. I've never seen or heard of it actually being used. Presumably it was once useful for skipping hardware initialization when reloading the module over and over during driver development.. Signed-off-by: Andres Salomon Signed-off-by: Greg Kroah-Hartman --- diff --git a/drivers/staging/olpc_dcon/olpc_dcon.c b/drivers/staging/olpc_dcon/olpc_dcon.c index 750fe50..cf4b454 100644 --- a/drivers/staging/olpc_dcon/olpc_dcon.c +++ b/drivers/staging/olpc_dcon/olpc_dcon.c @@ -36,9 +36,6 @@ static int resumeline = 898; module_param(resumeline, int, 0444); -static int noinit; -module_param(noinit, int, 0444); - /* Default off since it doesn't work on DCON ASIC in B-test OLPC board */ static int useaa = 1; module_param(useaa, int, 0444); @@ -90,7 +87,7 @@ static int dcon_hw_init(struct dcon_priv *dcon, int is_init) } } - if (ver < 0xdc02 && !noinit) { + if (ver < 0xdc02) { /* Initialize the DCON registers */ /* Start with work-arounds for DCON ASIC */ @@ -106,7 +103,7 @@ static int dcon_hw_init(struct dcon_priv *dcon, int is_init) i2c_smbus_write_word_data(client, 0x3b, 0x002b); i2c_smbus_write_word_data(client, 0x41, 0x0101); i2c_smbus_write_word_data(client, 0x42, 0x0101); - } else if (!noinit) { + } else { /* SDRAM setup/hold time */ i2c_smbus_write_word_data(client, 0x3a, 0xc040); i2c_smbus_write_word_data(client, 0x41, 0x0000);