From: Simon Glass <sjg@chromium.org>
Date: Mon, 30 Dec 2019 04:19:16 +0000 (-0700)
Subject: dm: core: Don't clear active flag twice when probe() fails
X-Git-Tag: submit/tizen_6.0/20211217.073345~37
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=24c3fded8ab0b67cb6be63d07e1fd9824a5b526e;p=platform%2Fkernel%2Fu-boot.git

dm: core: Don't clear active flag twice when probe() fails

Remove this duplicated code, since the 'fail' label does this immediately.

Change-Id: I445b8fc692343e071af7416989483ee39c1db94b
Signed-off-by: Simon Glass <sjg@chromium.org>
---

diff --git a/drivers/core/device.c b/drivers/core/device.c
index b46af87253..88f26b343f 100644
--- a/drivers/core/device.c
+++ b/drivers/core/device.c
@@ -423,10 +423,8 @@ int device_probe(struct udevice *dev)
 
 	if (drv->probe) {
 		ret = drv->probe(dev);
-		if (ret) {
-			dev->flags &= ~DM_FLAG_ACTIVATED;
+		if (ret)
 			goto fail;
-		}
 	}
 
 	ret = uclass_post_probe_device(dev);