From: Andrii Nakryiko Date: Fri, 7 May 2021 05:41:17 +0000 (-0700) Subject: libbpf: Fix ELF symbol visibility update logic X-Git-Tag: accepted/tizen/unified/20230118.172025~6942^2~501^2~15 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=247b8634e6446dbc8024685f803290501cba226f;p=platform%2Fkernel%2Flinux-rpi.git libbpf: Fix ELF symbol visibility update logic Fix silly bug in updating ELF symbol's visibility. Fixes: a46349227cd8 ("libbpf: Add linker extern resolution support for functions and global variables") Signed-off-by: Andrii Nakryiko Signed-off-by: Alexei Starovoitov Link: https://lore.kernel.org/bpf/20210507054119.270888-6-andrii@kernel.org --- diff --git a/tools/lib/bpf/linker.c b/tools/lib/bpf/linker.c index 3b1fbc2..b594a88 100644 --- a/tools/lib/bpf/linker.c +++ b/tools/lib/bpf/linker.c @@ -1788,7 +1788,7 @@ static void sym_update_visibility(Elf64_Sym *sym, int sym_vis) /* libelf doesn't provide setters for ST_VISIBILITY, * but it is stored in the lower 2 bits of st_other */ - sym->st_other &= 0x03; + sym->st_other &= ~0x03; sym->st_other |= sym_vis; }