From: Jakob Botsch Nielsen Date: Thu, 2 Feb 2023 18:31:46 +0000 (+0100) Subject: Delete JIT disasm output in test wrappers before running FileCheck (#81538) X-Git-Tag: accepted/tizen/unified/riscv/20231226.055536~4262 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=2411d09d80a3a419f4d3b8754f3fde98bf11d144;p=platform%2Fupstream%2Fdotnet%2Fruntime.git Delete JIT disasm output in test wrappers before running FileCheck (#81538) JitStdOutFile has append behavior, so if you rerun the scripts you would get multiple repeated sets of jitdisasm. This would give FileCheck a much range of disassembly to match that was much wider than expected. --- diff --git a/src/tests/Common/CLRTest.Jit.targets b/src/tests/Common/CLRTest.Jit.targets index 2270f0b..31d9e15 100644 --- a/src/tests/Common/CLRTest.Jit.targets +++ b/src/tests/Common/CLRTest.Jit.targets @@ -235,6 +235,7 @@ if [[ ( -z "$DOTNET_JitStress" ) && ( -z "$DOTNET_JitStressRegs" ) && ( -z "$DOT export DOTNET_JitDisasm=`cat $(BashDisasmListOutputFile)` export DOTNET_JitDiffableDasm=1 export DOTNET_JitStdOutFile=$(BashDisasmOutputFile) + rm -f $(BashDisasmOutputFile) if [[ $ERRORLEVEL -ne 0 ]] then echo EXECUTION OF FILECHECK - FAILED $ERRORLEVEL @@ -281,6 +282,7 @@ IF "%DOTNET_JitStress%"=="" IF "%DOTNET_JitStressRegs%"=="" IF "%DOTNET_Tailcall for /F "delims=" %%g in ($(BatchDisasmListOutputFile)) do set DOTNET_JitDisasm=%%g set DOTNET_JitDiffableDasm=1 set DOTNET_JitStdOutFile=$(BatchDisasmOutputFile) + del $(BatchDisasmOutputFile) >nul 2>&1 ) ]]>