From: Colin Ian King <colin.king@canonical.com>
Date: Wed, 9 Jun 2021 17:33:12 +0000 (+0100)
Subject: ACPI: scan: initialize local variable to avoid garbage being returned
X-Git-Tag: accepted/tizen/unified/20230118.172025~6955^2~21^2
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=23db673d7e5194c8fbbb8c307e23960767305c09;p=platform%2Fkernel%2Flinux-rpi.git

ACPI: scan: initialize local variable to avoid garbage being returned

In the unlikely event that there are no callback calls made in
acpi_walk_dep_device_list(), local variable ret will be returned as
an uninitialized value.

Clean up static analysis warnings by ensuring ret is initialized.

Addresses-Coverity: ("Uninitialized scalar variable")
Fixes: a9e10e587304 ("ACPI: scan: Extend acpi_walk_dep_device_list()")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Reviewed-by: Daniel Scally <djrscally@gmail.com>
[ rjw: Subject and changelog edits ]
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
---

diff --git a/drivers/acpi/scan.c b/drivers/acpi/scan.c
index 708c1d8..f64119a 100644
--- a/drivers/acpi/scan.c
+++ b/drivers/acpi/scan.c
@@ -2150,7 +2150,7 @@ int acpi_walk_dep_device_list(acpi_handle handle,
 			      void *data)
 {
 	struct acpi_dep_data *dep, *tmp;
-	int ret;
+	int ret = 0;
 
 	mutex_lock(&acpi_dep_list_lock);
 	list_for_each_entry_safe(dep, tmp, &acpi_dep_list, node) {