From: Thibault Saunier <tsaunier@igalia.com>
Date: Sat, 2 Mar 2019 01:57:48 +0000 (-0300)
Subject: source: No checks when linking default elements
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=23d3e69f2bd7f901b8084f9accef3c64e6df7ab1;p=platform%2Fupstream%2Fgst-editing-services.git

source: No checks when linking default elements
---

diff --git a/ges/ges-source.c b/ges/ges-source.c
index e70c4e5..f960349 100644
--- a/ges/ges-source.c
+++ b/ges/ges-source.c
@@ -96,8 +96,14 @@ ges_source_create_topbin (const gchar * bin_name, GstElement * sub_element, ...)
 
   while ((element = va_arg (argp, GstElement *)) != NULL) {
     gst_bin_add (GST_BIN (bin), element);
-    if (prev)
-      gst_element_link (prev, element);
+    if (prev) {
+      if (!gst_element_link_pads_full (prev, "src", element, "sink",
+              GST_PAD_LINK_CHECK_NOTHING)) {
+        g_error ("Could not link %s and %s",
+            GST_OBJECT_NAME (prev), GST_OBJECT_NAME (element));
+      }
+
+    }
     prev = element;
     if (first == NULL)
       first = element;
@@ -117,7 +123,7 @@ ges_source_create_topbin (const gchar * bin_name, GstElement * sub_element, ...)
 
     sinkpad = gst_element_get_static_pad (first, "sink");
     if (sub_srcpad)
-      gst_pad_link (sub_srcpad, sinkpad);
+      gst_pad_link_full (sub_srcpad, sinkpad, GST_PAD_LINK_CHECK_NOTHING);
     else
       g_signal_connect (sub_element, "pad-added", G_CALLBACK (_pad_added_cb),
           sinkpad);