From: Dan Carpenter Date: Sat, 19 May 2018 06:37:15 +0000 (+0300) Subject: firmware: arm_scmi: remove some unnecessary checks X-Git-Tag: v4.19~280^2~16^2 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=23cae492b4ed8cb2eb741f21a48bfd712960e87f;p=platform%2Fkernel%2Flinux-rpi3.git firmware: arm_scmi: remove some unnecessary checks The "pi->dom_info" buffer is allocated in init() and it can't be NULL here. These tests are sort of weird as well because if "pi->dom_info" was NULL but "domain" was non-zero then it would lead to an Oops. Signed-off-by: Dan Carpenter Signed-off-by: Sudeep Holla --- diff --git a/drivers/firmware/arm_scmi/perf.c b/drivers/firmware/arm_scmi/perf.c index 2a219b1..721e6c5 100644 --- a/drivers/firmware/arm_scmi/perf.c +++ b/drivers/firmware/arm_scmi/perf.c @@ -363,8 +363,6 @@ static int scmi_dvfs_device_opps_add(const struct scmi_handle *handle, return domain; dom = pi->dom_info + domain; - if (!dom) - return -EIO; for (opp = dom->opp, idx = 0; idx < dom->opp_count; idx++, opp++) { freq = opp->perf * dom->mult_factor; @@ -394,9 +392,6 @@ static int scmi_dvfs_transition_latency_get(const struct scmi_handle *handle, return domain; dom = pi->dom_info + domain; - if (!dom) - return -EIO; - /* uS to nS */ return dom->opp[dom->opp_count - 1].trans_latency_us * 1000; }