From: Miroslav Urbanek Date: Thu, 5 Feb 2015 15:36:50 +0000 (+0100) Subject: flowcache: Fix kernel panic in flow_cache_flush_task X-Git-Tag: v4.14-rc1~5989^2~3^2~15 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=233c96fc077d310772375d47522fb444ff546905;p=platform%2Fkernel%2Flinux-rpi.git flowcache: Fix kernel panic in flow_cache_flush_task flow_cache_flush_task references a structure member flow_cache_gc_work where it should reference flow_cache_flush_task instead. Kernel panic occurs on kernels using IPsec during XFRM garbage collection. The garbage collection interval can be shortened using the following sysctl settings: net.ipv4.xfrm4_gc_thresh=4 net.ipv6.xfrm6_gc_thresh=4 With the default settings, our productions servers crash approximately once a week. With the settings above, they crash immediately. Fixes: ca925cf1534e ("flowcache: Make flow cache name space aware") Reported-by: Tomáš Charvát Tested-by: Jan Hejl Signed-off-by: Miroslav Urbanek Acked-by: Eric Dumazet Signed-off-by: David S. Miller --- diff --git a/net/core/flow.c b/net/core/flow.c index a0348fd..1033725 100644 --- a/net/core/flow.c +++ b/net/core/flow.c @@ -379,7 +379,7 @@ done: static void flow_cache_flush_task(struct work_struct *work) { struct netns_xfrm *xfrm = container_of(work, struct netns_xfrm, - flow_cache_gc_work); + flow_cache_flush_work); struct net *net = container_of(xfrm, struct net, xfrm); flow_cache_flush(net);