From: Dan Carpenter Date: Tue, 2 Oct 2012 08:27:14 +0000 (+0300) Subject: target/usb-gadget: strlen() doesn't count the terminator X-Git-Tag: v3.7-rc1~61^2~7 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=232ebe34e1a7827c9ddd4f31e95e21ba498ae52c;p=profile%2Fivi%2Fkernel-adaptation-intel-automotive.git target/usb-gadget: strlen() doesn't count the terminator We need to take the terminator into consideration here or the last character gets silently truncated away later. Signed-off-by: Dan Carpenter Signed-off-by: Nicholas Bellinger --- diff --git a/drivers/usb/gadget/tcm_usb_gadget.c b/drivers/usb/gadget/tcm_usb_gadget.c index 0f75f23..5662d6e 100644 --- a/drivers/usb/gadget/tcm_usb_gadget.c +++ b/drivers/usb/gadget/tcm_usb_gadget.c @@ -1815,7 +1815,7 @@ static ssize_t tcm_usbg_tpg_store_nexus( ret = tcm_usbg_drop_nexus(tpg); return (!ret) ? count : ret; } - if (strlen(page) > USBG_NAMELEN) { + if (strlen(page) >= USBG_NAMELEN) { pr_err("Emulated NAA Sas Address: %s, exceeds" " max: %d\n", page, USBG_NAMELEN); return -EINVAL;