From: Josh Hunt <johunt@akamai.com>
Date: Sun, 10 Sep 2017 19:48:50 +0000 (-0400)
Subject: net/sched: fix pointer check in gen_handle
X-Git-Tag: v4.14-rc1~3^2~30
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=230cfd2dbc228a6992287d31c5d93bc6c2552024;p=platform%2Fkernel%2Flinux-rpi.git

net/sched: fix pointer check in gen_handle

Fixes sparse warning about pointer in gen_handle:
net/sched/cls_rsvp.h:392:40: warning: Using plain integer as NULL pointer

Fixes: 8113c095672f6 ("net_sched: use void pointer for filter handle")
Signed-off-by: Josh Hunt <johunt@akamai.com>
Acked-by: Cong Wang <xiyou.wangcong@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
---

diff --git a/net/sched/cls_rsvp.h b/net/sched/cls_rsvp.h
index 98c05db..b1f6ed4 100644
--- a/net/sched/cls_rsvp.h
+++ b/net/sched/cls_rsvp.h
@@ -389,7 +389,7 @@ static unsigned int gen_handle(struct tcf_proto *tp, unsigned salt)
 		if ((data->hgenerator += 0x10000) == 0)
 			data->hgenerator = 0x10000;
 		h = data->hgenerator|salt;
-		if (rsvp_get(tp, h) == 0)
+		if (!rsvp_get(tp, h))
 			return h;
 	}
 	return 0;