From: Mika Kukkonen <mikukkon@gmail.com>
Date: Tue, 6 Sep 2005 22:17:17 +0000 (-0700)
Subject: [PATCH] create_workqueue_thread() signedness fix
X-Git-Tag: v2.6.14-rc1~692
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=230649da7cb73914b8b2a1ffc802a2951e970454;p=platform%2Fkernel%2Flinux-exynos.git

[PATCH] create_workqueue_thread() signedness fix

With "-W -Wno-unused -Wno-sign-compare" I get the following compile warning:

  CC      kernel/workqueue.o
kernel/workqueue.c: In function `workqueue_cpu_callback':
kernel/workqueue.c:504: warning: ordered comparison of pointer with integer zero

On error create_workqueue_thread() returns NULL, not negative pointer, so
following trivial patch suggests itself.

Signed-off-by: Mika Kukkonen <mikukkon@gmail.com>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
---

diff --git a/kernel/workqueue.c b/kernel/workqueue.c
index c7e36d4..a3de837 100644
--- a/kernel/workqueue.c
+++ b/kernel/workqueue.c
@@ -499,7 +499,7 @@ static int __devinit workqueue_cpu_callback(struct notifier_block *nfb,
 	case CPU_UP_PREPARE:
 		/* Create a new workqueue thread for it. */
 		list_for_each_entry(wq, &workqueues, list) {
-			if (create_workqueue_thread(wq, hotcpu) < 0) {
+			if (!create_workqueue_thread(wq, hotcpu)) {
 				printk("workqueue for %i failed\n", hotcpu);
 				return NOTIFY_BAD;
 			}