From: Clément Léger <cleger@rivosinc.com>
Date: Tue, 9 Apr 2024 10:02:04 +0000 (+0200)
Subject: lib: sbi: sse: simplify 32bits overflow check
X-Git-Tag: v1.5~47
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=22ff75099c53a4bac72abc3fa10157aabeb3ce49;p=platform%2Fkernel%2Fopensbi.git

lib: sbi: sse: simplify 32bits overflow check

Rather than checking 32bits overflow with some absolute value, check the
value to be different from the cast itself.

Signed-off-by: Clément Léger <cleger@rivosinc.com>
Reported-by: Samuel Holland <samuel.holland@sifive.com>
Reviewed-by: Anup Patel <anup@brainfault.org>
---

diff --git a/lib/sbi/sbi_sse.c b/lib/sbi/sbi_sse.c
index 0f8b347..1b6048d 100644
--- a/lib/sbi/sbi_sse.c
+++ b/lib/sbi/sbi_sse.c
@@ -344,7 +344,7 @@ static int sse_event_set_attr_check(struct sbi_sse_event *e, uint32_t attr_id,
 		break;
 	case SBI_SSE_ATTR_PRIO:
 #if __riscv_xlen > 32
-		if (val > 0xFFFFFFFFUL) {
+		if (val != (uint32_t)val) {
 			ret = SBI_EINVAL;
 			break;
 		}