From: H Hartley Sweeten Date: Mon, 20 Oct 2014 18:34:29 +0000 (-0700) Subject: staging: comedi: addi_apci_3120: don't reset board when detaching driver X-Git-Tag: v5.15~16669^2~797 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=22be3f81429608aad8229ee60e8f834024291f09;p=platform%2Fkernel%2Flinux-starfive.git staging: comedi: addi_apci_3120: don't reset board when detaching driver The comedi core calls all the subdevice (*cancel) functions before it does the driver (*detach). There is no reason to call the board reset function in the (*detach). Signed-off-by: H Hartley Sweeten Reviewed-by: Ian Abbott Signed-off-by: Greg Kroah-Hartman --- diff --git a/drivers/staging/comedi/drivers/addi_apci_3120.c b/drivers/staging/comedi/drivers/addi_apci_3120.c index 3b4fa2e..e5dbbdf 100644 --- a/drivers/staging/comedi/drivers/addi_apci_3120.c +++ b/drivers/staging/comedi/drivers/addi_apci_3120.c @@ -239,8 +239,6 @@ static int apci3120_auto_attach(struct comedi_device *dev, static void apci3120_detach(struct comedi_device *dev) { - if (dev->iobase) - apci3120_reset(dev); comedi_pci_detach(dev); apci3120_dma_free(dev); }