From: J. Bruce Fields Date: Fri, 17 May 2019 20:22:18 +0000 (-0400) Subject: nfsd: note inadequate stats locking X-Git-Tag: v5.4-rc1~621^2~31 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=22a46eb44016eec3384da3731a2d47a5d3c91955;p=platform%2Fkernel%2Flinux-rpi.git nfsd: note inadequate stats locking After 89a26b3d295d "nfsd: split DRC global spinlock into per-bucket locks", there is no longer a single global spinlock to protect these stats. So, really we need to fix that. For now, at least fix the comment. Signed-off-by: J. Bruce Fields --- diff --git a/fs/nfsd/netns.h b/fs/nfsd/netns.h index 46240c4..ceb413f 100644 --- a/fs/nfsd/netns.h +++ b/fs/nfsd/netns.h @@ -142,8 +142,11 @@ struct nfsd_net { unsigned int drc_hashsize; /* - * Stats and other tracking of on the duplicate reply cache. All of these and - * the "rc" fields in nfsdstats are protected by the cache_lock + * Stats and other tracking of on the duplicate reply cache. + * These fields and the "rc" fields in nfsdstats are modified + * with only the per-bucket cache lock, which isn't really safe + * and should be fixed if we want the statistics to be + * completely accurate. */ /* total number of entries */