From: Seunghun Lee <shiin.lee@samsung.com>
Date: Wed, 18 Dec 2019 06:17:12 +0000 (+0900)
Subject: video: Referencing 'E_Comp_Wl_Buffer' before pp commit.
X-Git-Tag: submit/tizen/20200214.070252~2
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=229249f6f0d345174962f6e0690162f84f79aa69;p=platform%2Fupstream%2Fenlightenment.git

video: Referencing 'E_Comp_Wl_Buffer' before pp commit.

A handler for pp commit done can be called directly in tdm_pp_commit().
Therefore, a buffer has to be referenced before calling it for safety.

Change-Id: Ief542676d8f6425e4951598796140f8cceb740c6
---

diff --git a/src/bin/video/iface/e_video_hwc.c b/src/bin/video/iface/e_video_hwc.c
index 00572cb2fe..21a6b2b50c 100644
--- a/src/bin/video/iface/e_video_hwc.c
+++ b/src/bin/video/iface/e_video_hwc.c
@@ -558,13 +558,13 @@ _e_video_hwc_pp_render(E_Video_Hwc *evh, E_Comp_Wl_Buffer *comp_buffer)
    if (!pp_buffer)
      goto render_fail;
 
+   e_comp_wl_video_buffer_set_use(pp_buffer, EINA_TRUE);
+   e_comp_wl_buffer_reference(&input_buffer->buffer_ref, input_buffer->comp_buffer);
+
    res = _e_video_hwc_pp_commit(evh->pp, input_buffer, pp_buffer, evh->geo.tdm.transform);
    if (!res)
      goto render_fail;
 
-   e_comp_wl_video_buffer_set_use(pp_buffer, EINA_TRUE);
-   e_comp_wl_buffer_reference(&input_buffer->buffer_ref, input_buffer->comp_buffer);
-
    return EINA_TRUE;
 
 render_fail: