From: Stefan Weil <sw@weilnetz.de>
Date: Sat, 1 Sep 2012 07:30:39 +0000 (+0200)
Subject: qapi: Fix potential NULL pointer segfault
X-Git-Tag: TizenStudio_2.0_p2.3.2~208^2~3606^2~10
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=227ccf6bff234c29974c2c18ecd3a29e6b965e3d;p=sdk%2Femulator%2Fqemu.git

qapi: Fix potential NULL pointer segfault

Report from smatch:

qapi-visit.c:1640 visit_type_BlockdevAction(8) error:
 we previously assumed 'obj' could be null (see line 1639)
qapi-visit.c:2432 visit_type_NetClientOptions(8) error:
 we previously assumed 'obj' could be null (see line 2431)

Signed-off-by: Stefan Weil <sw@weilnetz.de>
Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>
Signed-off-by: Luiz Capitulino <lcapitulino@redhat.com>
---

diff --git a/scripts/qapi-visit.py b/scripts/qapi-visit.py
index cbec24d..e2093e8 100644
--- a/scripts/qapi-visit.py
+++ b/scripts/qapi-visit.py
@@ -157,7 +157,7 @@ void visit_type_%(name)s(Visitor *m, %(name)s ** obj, const char *name, Error **
     if (!error_is_set(errp)) {
         visit_start_struct(m, (void **)obj, "%(name)s", name, sizeof(%(name)s), &err);
         if (!err) {
-            if (!obj || *obj) {
+            if (obj && *obj) {
                 visit_type_%(name)sKind(m, &(*obj)->kind, "type", &err);
                 if (!err) {
                     switch ((*obj)->kind) {