From: Hans de Goede Date: Wed, 17 Feb 2021 10:25:01 +0000 (+0100) Subject: misc: lis3lv02d: Do not log an error when kmalloc fails X-Git-Tag: accepted/tizen/unified/20230118.172025~7416^2~94 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=2278f0c385d88a3898d0e977d6e80e5d3d3d6020;p=platform%2Fkernel%2Flinux-rpi.git misc: lis3lv02d: Do not log an error when kmalloc fails Logging an error when kmalloc fails is not necessary (and in general should be avoided) because the malloc failure will already complain loudly itself. Signed-off-by: Hans de Goede Link: https://lore.kernel.org/r/20210217102501.31758-3-hdegoede@redhat.com Signed-off-by: Greg Kroah-Hartman --- diff --git a/drivers/misc/lis3lv02d/lis3lv02d.c b/drivers/misc/lis3lv02d/lis3lv02d.c index 22dacfa..70c5bb1 100644 --- a/drivers/misc/lis3lv02d/lis3lv02d.c +++ b/drivers/misc/lis3lv02d/lis3lv02d.c @@ -1179,10 +1179,8 @@ int lis3lv02d_init_device(struct lis3lv02d *lis3) lis3->reg_cache = kzalloc(max(sizeof(lis3_wai8_regs), sizeof(lis3_wai12_regs)), GFP_KERNEL); - if (lis3->reg_cache == NULL) { - printk(KERN_ERR DRIVER_NAME "out of memory\n"); + if (lis3->reg_cache == NULL) return -ENOMEM; - } mutex_init(&lis3->mutex); atomic_set(&lis3->wake_thread, 0);