From: Rich Trott <rtrott@gmail.com>
Date: Fri, 26 Jun 2015 01:54:25 +0000 (-0700)
Subject: test: clarify dropMembership() call
X-Git-Tag: v4.0.0-rc.1~188
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=226b8e0cf8374a0074142145858fa0aa94bca3ce;p=platform%2Fupstream%2Fnodejs.git

test: clarify dropMembership() call

According to docs, dropMembership() is automatically called
by the kernel when the socket is closed, and most apps will
never need to call it. It's called here as a sanity check
only so let's note that with a comment.

Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
PR-URL: https://github.com/nodejs/io.js/pull/2062
---

diff --git a/test/internet/test-dgram-multicast-multi-process.js b/test/internet/test-dgram-multicast-multi-process.js
index 05acb844e..34db38331 100644
--- a/test/internet/test-dgram-multicast-multi-process.js
+++ b/test/internet/test-dgram-multicast-multi-process.js
@@ -3,7 +3,6 @@ var common = require('../common'),
     assert = require('assert'),
     dgram = require('dgram'),
     util = require('util'),
-    assert = require('assert'),
     Buffer = require('buffer').Buffer,
     fork = require('child_process').fork,
     LOCAL_BROADCAST_HOST = '224.0.0.114',
@@ -183,10 +182,9 @@ if (process.argv[2] === 'child') {
     process.send({ message: buf.toString() });
 
     if (receivedMessages.length == messages.length) {
+      // .dropMembership() not strictly needed but here as a sanity check
       listenSocket.dropMembership(LOCAL_BROADCAST_HOST);
-
-      process.nextTick(function() { // TODO should be changed to below.
-        // listenSocket.dropMembership(LOCAL_BROADCAST_HOST, function() {
+      process.nextTick(function() {
         listenSocket.close();
       });
     }